Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Move Source implementations to a single folder #2685

Closed
wants to merge 1 commit into from
Closed

✨Move Source implementations to a single folder #2685

wants to merge 1 commit into from

Conversation

inteon
Copy link
Member

@inteon inteon commented Feb 13, 2024 •
edited
Loading

Moves all the source logic to the same directory, making it easier to understand and refactor in the future.
Currently pkg/source/source.go contains the Channel, Informer and Func source, while the Kind source lives in the pkg/source/internal/kind.go file.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inteon
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2024
This was referenced Feb 13, 2024
Open
Closed
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@Danil-Grigorev Danil-Grigorev mentioned this pull request Apr 20, 2024
Merged
@inteon
move all Source implementations to a single folder
22f4a15 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon changed the title ✨Move Source definitions to a single folder without breaking the API ✨Move Source definitions to a single folder Apr 22, 2024
@inteon inteon changed the title ✨Move Source definitions to a single folder ✨Move Source implementations to a single folder Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 22, 2024 •
edited
Loading

@inteon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff 22f4a15 link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@inteon
Copy link
Member Author

inteon commented Apr 22, 2024

@alvaroaleman could you take a look at this PR too?
It should be purely code cleanup/ re-organisation.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
alvaroaleman
alvaroaleman requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves all the source logic to the same directory, making it easier to understand and refactor in the future.

What is or isn't easier to understand in terms of file layout extremely subjective while not mattering too much in practise due to IDE tooling. At the same time a change like this has a cost in review capacity and in that it breaks git blame. Given that there is no clear benefit but a clear cost I'm -1 to this.

@inteon inteon closed this Apr 23, 2024
@inteon
Copy link
Member Author

inteon commented Apr 23, 2024

Moves all the source logic to the same directory, making it easier to understand and refactor in the future.

What is or isn't easier to understand in terms of file layout extremely subjective while not mattering too much in practise due to IDE tooling. At the same time a change like this has a cost in review capacity and in that it breaks git blame. Given that there is no clear benefit but a clear cost I'm -1 to this.

Thanks for the feedback. I updated #2686 so it does no longer depend on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman requested changes

@FillZpp FillZpp Awaiting requested review from FillZpp

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@alvaroaleman alvaroaleman

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @k8s-ci-robot @alvaroaleman